First cut of seismic waveform example
It's in a reasonably presentable state, but could always use further improvements.
@robambalu Latest commit should incorporate all your feedback
@AdamGlustein All your other feedback is incorporated, but I would also love an answer to the units question, so leaving that one open for now.
EasySeedLinkAdapteris pretty useless on its own, i would combine withEasySeedLinkAdapterImplas here.Also
EasySeedLinkAdapterImpl/_EasySeedLinkAdapterImpl,EasySeedLinkAdapter/_EasySeedLinkAdapteris pretty awful naming unless the goal is to confuse the reader 😆
I will have a look at this - I probably copied the wrong example
@timkpaine I've updated the adapter definition - agree it's much more straightforward now. @AdamGlustein I've added a link to the USGS FAQ on seismography that has more background information about the space for lay people.
- [ ] Needs tests
- [ ]
README.mdin07_end_to_endsimilar to this- [ ] Outputs stripped (meh) or notebook stored in LFS (also meh)
As discussed offline, always keen on testing, let's discuss strategies next week. I will also follow up on the longer term question about binary assets in the repo and possible move to LFS or separate repo for binary-heavy examples/notebooks.
- [ ] Needs tests
- [ ]
README.mdin07_end_to_endsimilar to this- [ ] Outputs stripped (meh) or notebook stored in LFS (also meh)
As discussed, we will work on tests separately. I think we can also put together a README for the section in a separate PR.