PoglyApp
URLEncode Authentication Key
We need to URLEncode the Authentication Key when being set, and used, throughout Pogly.
If you use any of the below special characters in your AuthenticationKey, the streamer's /overlay url has the potential to be misinterpreted:
For example:
https://standalone.pogly.gg/overlay?module=pogly_issue_example&domain=wss://testnet.spacetimedb.com&auth=MY#AUTHKEY
Authkey MY#AUTHKEY will be interpreted by the browser as MY, failing to connect.
immediate bug fixed in 93b7f827fb315e6d0c3338c3a01622e00f8425ec with bandaid fix.
Proper fix will come during next breaking window- I'm not entirely sure how logic changes in the authentication reducer will effect things, so even though it's not a table breaking change, it's best to slot the proper fix in then.
This doesn't really work in the current state where the /overlay route uses the auth key in the URL.
If we URLEncode the auth key, the key given in the /overlay route URL will need to be URLEncoded... which you can't really do by hand unless you know all the codes.
This means that we'd have to have like a "Copy stream overlay URL" button somewhere in the overlay instance- probably in the settings... but also I kind of hate that.
I'm gonna tag this one as "wontfix" as it's low prio for now.