alembic-postgresql-enum icon indicating copy to clipboard operation
alembic-postgresql-enum copied to clipboard

Add tests and support for enum names which are camel case. Fixes: #11…

Open Apteryx0 opened this issue 8 months ago • 0 comments

Description

Our org recently added alembic-postgresql-enum to our code-base, but we have legacy enums with camel-case names, which caused a very specific error just sql that renames the enum type to <enum>_old. The rename_type function expects arguments to be quoted - this changes ensures that the enum type name is.

Oh, I originally mistakenly edited test_exotic_column_name.py before realising it was the wrong test. I left it in there since I guess it does test CamelCase column names now...? :-)

Fixes: #110

Checklist

This pull request is:

  • [ ] A documentation / typographical / small typing error fix
    • Good to go, no issue or tests are needed
  • [X] A short code fix
    • please include the issue number, and create an issue if none exists, which must include a complete example of the issue. one line code fixes without an issue and demonstration will not be accepted.
    • Please include: Fixes: #<issue number> in the commit message
    • please include tests. one line code fixes without tests will not be accepted.
  • [ ] A new feature implementation
    • please include the issue number, and create an issue if none exists, which must include a complete example of how the feature would look.
    • Please include: Fixes: #<issue number> in the commit message
    • please include tests.

Have a nice day!

Apteryx0 avatar Apr 17 '25 21:04 Apteryx0