[git-exporter] clean repo before proceeding

[bjeanes]

After successive dry-runs, if exclude option is amended, now-excluded files will accumulate in the git directory with no real way to discard them.

Running git clean after clone will ensure a clean slate before re-rsyncing files over and git adding them.

[bjeanes]

Use-case: I have Syncthing add-on enabled and had versioning turned on. This created a .stversions directory which was copied across before I excluded it. Once I moved legitimate secrets to the secrets.yaml, old versions in .stversions were being caught by the secrets scan and preventing commit.

Short of uninstalling the add-on to clear the data mount, this seems like the best course. It also seems to me that it would minimise the chance of accidental commits as the add-on config evolved.

[bjeanes]

Or perhaps rsync --delete-excluded is sufficient here. I'm inclined to say that both are worthwhile, but what do you think?

[Poeschl]

I would think a git clean should be sufficient after the clone. Cleaning old files is for sure something this addon was lacking. I will test it out, when I find some time and will merge it afterwards ;)

Can you please add an Changelog text with a new Minor-increased version?

[bjeanes]

Hmm I didn't want to do changelog with a specific version or date because I don't yet know when it will be merged or released. And because I opened 2 PRs without knowing if one/both would be merged, a version bump would cause a conflict.

I can put today's date though and you can change it I suppose.

[bjeanes]

I'm not sure what your Emoji scheme is in Changelog. It differs from https://github.com/favoloso/conventional-changelog-emoji which is the one I have seen before.

I see you've used 🔨, 🔧, and ➕ for similar changes in the past. How would you annotate this change?

[Poeschl]

@bjeanes I would just use the hammer for it.

Seems that I need to think about a dev branch 😅 Hoped I don't need one for my free-time project.

Also looking into auto-generated Changelogs 😁

[bjeanes]

Also looking into auto-generated Changelogs 😁

How I usually do this is that PRs must add changelog entries under an Unreleased changes heading and do NOT increment versions.

Then, as part of release/delpoy process, version is incremented, heading is renamed to version with current date, and a new empty "Unreleased changes" section is prepended to CHANGELOG.md.

Hope that helps. Personally, I think auto-generated changelogs are usually pretty hard as a user because they haven't been curated/worded for that audience. Manual changes are good, but having PRs bump versions can be hell when you have lots of concurrent PRs!

[Poeschl]

@bjeanes I was thinking about some special tag, which can be attached to the commit message and contains a suitable user changelog message. 😉

Thanks for your input 😁

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[Poeschl]

Shh bot, no time to review, but not stale 😅

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.