Hassio-Addons icon indicating copy to clipboard operation
Hassio-Addons copied to clipboard

git-exporter: add extra secrets patterns and _allowed_ secrets patterns

Open bjeanes opened this issue 2 years ago • 1 comments

Which addon?

git exporter

Is your feature request related to a problem? Please describe.

I have a lot of little Mijia BLE humidity/temperature sensors around the house. The MAC addresses get triggered as secrets when they aren't sensitive (to me). I'd like to be able to allow them.

On the other hand, it does not detect the bind_key: <secret> for those sensors, which should be a secret.

Describe the solution you'd like

Ideally, the add-on would have two options, both lists of strings, that would be iterated when secret patterns are configured in Git by the add-on

Describe alternatives you've considered

I can't think of an alternative for adding extra secrets based on how the add-on works (to the extent I can understand run.sh). I think I could turn off secret checking, commit the ones I wish to preserve, then turn it back on and it might skip future checks. I am not 100% sure this is how git secrets works, but it is a workaround I am considering.

Additional context

n/a

bjeanes avatar May 01 '22 02:05 bjeanes

Another example for allowing a secret is to allow something like a local/non-sensitive subnet (e.g. 172.16.0.0/12, which in this case is just to allow other Docker containers to act as proxies)

bjeanes avatar May 01 '22 02:05 bjeanes

MR merged

Poeschl avatar Nov 05 '22 12:11 Poeschl