MCEdit-Unified icon indicating copy to clipboard operation
MCEdit-Unified copied to clipboard

CB commands, Add conditional commands to chain.

Open firefish5000 opened this issue 8 years ago • 5 comments

I was enjoying generating and pasting commands with the CB Commands chain option, but I had a few chains I had to individually select if I wanted them to be logically sorted.

I am guessing that conditionals separate data values were just missed since they are rather new. But if it was intentional, please note that the rest of the chain gets executed even if the conditional links are not, as such, it is not a good idea to consider a conditional chain block as a new chain.

firefish5000 avatar May 20 '16 18:05 firefish5000

Second commit separates chain grouping from sorting, and adds a lot more sort options. just XYZ/ZYX wasn't enough for me to easily automate what I was doing.

I am not use to python, and am positive that the second commit needs a few changes.

firefish5000 avatar May 21 '16 11:05 firefish5000

Just let us know when it's ready and I'll merge, some command block stuff was missed simply because I don't think any of us follow command blocks that closely.

Khroki avatar May 21 '16 15:05 Khroki

Let also think about compatibility between MC versions.

I don't know how command blocks are working, but, if someone wants to edit a 1.8 command block, we shall not corrupt the save with 1.9 data.

LaChal avatar May 21 '16 19:05 LaChal

Wondering if you are still working on this or not?

Khroki avatar Jun 13 '16 22:06 Khroki

Sorry, an unplanned family vacation has robed me of my usual programming environment and most of my screens.I'll try to work on it while here, but if I cannot, you can expect something in 8 days for sure.

Naturally, ill update my branch if any conflicts arise. I believe I am pretty much done on my side other than updating the config. I am thinking now that I should just translate xz and zx to xyz and zyx (i believe those were original, hard to look it up on this tablet) in the conditionals in select.py and fileedit.py rather than in the config file. Unfortunately, pyparser/pyconfig/whatever it is.... is a bit too difficult for me to wrap my head around at the moment

firefish5000 avatar Jun 14 '16 16:06 firefish5000