pocket-ios icon indicating copy to clipboard operation
pocket-ios copied to clipboard

Enable complete concurrency on PocketKit #2

Open Gio2018 opened this issue 1 year ago • 1 comments

Goal

  • Continue addressing Swift 6 warning on PocketKit, after enabling complete concurrency

Test Steps

  • Test everything as much as you can

Gio2018 avatar Jun 05 '24 19:06 Gio2018

Messages
:book: No SwiftLint violations! 🎉
:book: Project coverage: 37.02%
:book: Checking XCode Environment Variables
:book: Edited 46 files
:book: Created 2 files

Analytics: Coverage: 59.31

File Coverage
PocketSnowplowTracker.swift 96.25%

PocketKit: Coverage: 62.72

File Coverage
CollectionViewController.swift 78.9%
HomeViewController.swift 69.61%
VimeoComponentCell.swift 0.0% ⚠️
SectionHeaderView.swift 94.94%
HomeViewModel.swift 65.11%
VimeoComponentPresenter.swift 0.0% ⚠️
PocketAppDelegate.swift 86.59%
SendableItemAction.swift 38.25% ⚠️
CollectionStoryViewModel.swift 71.13%
CollectionViewModel.swift 83.97%
SavedItemViewModel.swift 42.88% ⚠️
PremiumUpgradeView.swift 89.49%
ImageComponentCell.swift 75.18%
SavesContainerViewController.swift 74.41%
RecommendableItemViewModel.swift 81.95%
MainView.swift 98.69%
UIApplication+BackgroundTaskManager.swift 100.0%

SharedPocketKit: Coverage: 62.45

File Coverage
ExtensionContext.swift 0.0% ⚠️

Sync: Coverage: 71.93

File Coverage
CollectionService.swift 84.62%
SyncOperationFactory.swift 70.37%
NetworkPathMonitor.swift 19.05% ⚠️
AsyncOperation.swift 64.86%
OEmbedService.swift 92.86%
PocketSource.swift 58.33%
FeatureFlagLoadingService.swift 20.0% ⚠️
ApolloClient+Extensions.swift 96.59%
SlateService.swift 86.67%
RetriableOperation.swift 79.2%
UserService.swift 88.89%
OSNotificationCenter.swift 100.0%

SyncTests: Coverage: 22.69

File Coverage
RetriableOperationTests.swift 0.0% ⚠️
CollectionService.swift 30.77% ⚠️
FeatureFlagLoadingService.swift 22.11% ⚠️
UserService.swift 77.78%
SlateService.swift 80.0%
NetworkPathMonitor.swift 19.05% ⚠️
OEmbedService.swift 0.0% ⚠️
SyncOperationFactory.swift 48.15% ⚠️
ApolloClient+Extensions.swift 93.18%
AsyncOperation.swift 64.86%
PocketSource.swift 19.0% ⚠️
RetriableOperation.swift 62.4%
PocketSourceTests.swift 0.0% ⚠️
OSNotificationCenter.swift 40.0% ⚠️

SharedPocketKitTests: Coverage: 28.09

File Coverage
ExtensionContext.swift 0.0% ⚠️

ItemWidgets.appex: Coverage: 0.0

File Coverage
ItemWidgetsListView.swift 0.0% ⚠️
ItemWidgetsView.swift 0.0% ⚠️
ItemWidgetsRow.swift 0.0% ⚠️
ItemWidgetsContainerView.swift 0.0% ⚠️

AnalyticsTests: Coverage: 24.68

File Coverage
PocketSnowplowTracker.swift 92.5%

PocketKitTests: Coverage: 28.15

File Coverage
MainView.swift 99.35%
HomeViewModel.swift 43.91% ⚠️
SavesContainerViewController.swift 51.61%
ExtensionContext.swift 0.0% ⚠️
UIApplication+BackgroundTaskManager.swift 100.0%
RecommendableItemViewModel.swift 0.0% ⚠️
HomeViewController.swift 45.35% ⚠️
CollectionViewController.swift 0.0% ⚠️
CollectionStoryViewModel.swift 0.0% ⚠️
VimeoComponentPresenter.swift 0.0% ⚠️
CollectionViewModel.swift 0.0% ⚠️
PocketAppDelegate.swift 92.68%
PremiumUpgradeView.swift 0.0% ⚠️
SectionHeaderView.swift 94.94%
ImageComponentCell.swift 80.85%
VimeoComponentCell.swift 0.0% ⚠️
SavedItemViewModel.swift 21.04% ⚠️
MockSource.swift 0.0% ⚠️
SendableItemAction.swift 0.0% ⚠️
CollectionViewModelTests.swift 0.0% ⚠️

Generated by :no_entry_sign: Danger Swift against 377739c6a53c6820a5fa99b67f9faf5ad26bec45

pocket-ci avatar Jun 05 '24 19:06 pocket-ci