pocket-ios
pocket-ios copied to clipboard
Pocket
feat(Ads): add AdsStore
Summary
- Include short description of what this PR accomplishes
References
- Links to docs, tickets, designs if available
Implementation Details
- Overview of work that was implemented and changes made to the codebase
Test Steps
- Write out what QA should do to verify this change works as expected and hasn't introduced regressions. Can mention specific OS versions, devices, areas of the app to test as needed.
PR Checklist:
- [ ] Added Unit / UI tests
- [ ] Self Review (review, clean up, documentation, run tests)
- [ ] Basic Self QA
Screenshots
| Messages | |
|---|---|
| :book: | No SwiftLint violations! 🎉 |
| :book: | Project coverage: 36.69% |
| :book: | Checking XCode Environment Variables |
| :book: | Edited 2 files |
| :book: | Created 2 files |
PocketKit: Coverage: 60.88
| File | Coverage | |
|---|---|---|
| HomeViewModel.swift | 64.67% | ✅ |
| AdsStore.swift | 24.14% | ⚠️ |
| HomeViewController.swift | 61.35% | ✅ |
| AdCarouselCellConfiguration.swift | 92.68% | ✅ |
PocketKitTests: Coverage: 28.46
| File | Coverage | |
|---|---|---|
| HomeViewModel.swift | 42.39% | ⚠️ |
| AdsStore.swift | 24.14% | ⚠️ |
| HomeViewController.swift | 46.51% | ⚠️ |
| AdCarouselCellConfiguration.swift | 0.0% | ⚠️ |
Generated by :no_entry_sign: Danger Swift against bd40d5028c6b1a613a4a937366c98813350d99b4
