Plume icon indicating copy to clipboard operation
Plume copied to clipboard

Published 20 hours ago • verified publisher icon Plume-org

Force interface language by config file

Open DearRude opened this issue 5 years ago • 4 comments

As explained in #785, trying to force the language interface which specified in .env file.

I tried the commented code below and re-compiled the front, but nothing happened. Since I didn't find any other piece which gets browser language, I assume my method of recompilation is flawed. (Only do cargo web deploy -p plume-front --release)

So I made this WIP PR as @igalic suggested. 😁

DearRude avatar Jun 23 '20 04:06 DearRude

Codecov Report

Merging #792 into main will decrease coverage by 0.00%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #792      +/-   ##
==========================================
- Coverage   39.09%   39.08%   -0.01%     
==========================================
  Files          73       73              
  Lines        9756     9758       +2     
  Branches     2233     2233              
==========================================
  Hits         3814     3814              
- Misses       4885     4887       +2     
  Partials     1057     1057

codecov[bot] avatar Jun 23 '20 05:06 codecov[bot]

The issue with the front-end is that it runs in the browser: it can't access the environment variables of the server.

I think the solution would be to:

  • first, do this change on the server side, where you can access the environment variables from the configuration. This may require you to change Plume-org/rocket-i18n first
  • then, once this settings works on the server, add a lang property to every <html> tag we render, containing the language code that we chose to render the page
  • in the front-end, use this lang attribute to detect the language instead of relying on navigator.language as we currently do.

I hope this isn't too much. I can try to guide you more if need detailed steps, I know it can be hard to get started on a codebase you know nothing about. Feel free to ask me here or on Matrix if you have any questions.

elegaanz avatar Jun 23 '20 11:06 elegaanz

I assume my method of recompilation is flawed. (Only do cargo web deploy -p plume-front --release)

The feature is missing, so it's not the issue at hand, but doing just that was actually not sufficient. You must also rebuild Plume, as it's build script (build.rs) is the one copying files from target/ to where static files should be

trinity-1686a avatar Jun 23 '20 12:06 trinity-1686a

I give up on this. Could not make it work...

DearRude avatar Jun 26 '20 13:06 DearRude