Sébastien Morel

Results 36 comments of Sébastien Morel

`libgit2/git2go` v34 has been released yesterday! compliant with the last libgit2 `1.5` I have updated the code(thanks @kdambekalns ) no more need to compile anything statically, it just works now....

About your last comment, as mentioned here: https://github.com/ezsystems/ezpublish-kernel/pull/2410 The kernel *does NOT use* the `ezplatform.session.save_path` and it should be according to that: https://github.com/ezsystems/ezpublish-kernel/blob/master/eZ/Bundle/EzPublishCoreBundle/Resources/config/services.yml#L249 @andrerom, Am I completely mistaking here?

Oh right, there is an automated injection of a parameter "session.save_path" by symfony: https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php#L772 I did not know! I closed the other PR, this one still has sense, right?

hum sounds I am the only one in favor of my PR But I am still **not convinced**, let me try again ;-) ## Few feedbacks first: > But maybe...

there are still a lot of in the `default_parameters.yml` ``` env(MAILER_HOST): 127.0.0.1 env(MAILER_USER): ~ env(MAILER_PASSWORD): ~ # env(MAILER_PORT) is missing env(SEARCH_ENGINE): legacy env(SOLR_DSN): http://localhost:8983/solr env(SOLR_CORE): collection1 env(LOG_PATH): "%kernel.logs_dir%/%kernel.environment%.log" env(CACHE_POOL): "cache.app"...

hey @andrerom. It was a crazy week I did not have the time. I will today (that the beginning of a long sunday;) ). Agreed with 2.4, let's not do...

finally I've just done it now @andrerom and somehow those changes are really simple finally ;) and I think they are safe. So if you are up for 2.3 why...

thanks @MichaelDeBoey much cleaner ;-) changed and pushed! @sergiodxa the first piece of code will add the list of modules and imports (basically just the chunks). > see my screenshot...

I think we should remove the `` from the rendered page. I don't really know the internal of Remix but that must be there: https://github.com/remix-run/remix/blob/main/packages/remix-react/components.tsx#L633 ping @MichaelDeBoey Checking the header...