vcromclaim icon indicating copy to clipboard operation
vcromclaim copied to clipboard

Published 20 hours ago • verified publisher icon Plombo

Fix NES size patch

Open greyrogue opened this issue 10 years ago • 1 comments

I noticed the problem with the size calculation in nes_rom_extract.py. It should be app1.seek(romoffset+4) before the size calculation (missing +4). Otherwise you're reading the 'NES' string instead of the number of PRG and CHR banks. Also, I don't think any of the official ROMs will have the title footer, but I could be wrong. If they don't, the + 128 can be removed.

greyrogue avatar Jan 18 '15 19:01 greyrogue

You're right, thanks. I'll fix that when I get the chance.

Plombo avatar Feb 16 '15 17:02 Plombo