feign-reactive icon indicating copy to clipboard operation
feign-reactive copied to clipboard

FilteredReactiveRetryPolicy with ExceptionPopagationPolicy

Open AmanKamani opened this issue 1 year ago • 1 comments

FilteredReactiveRetryPolicy doesn't override the exceptionPropagationPolicy from ReactiveRetryPolicy. So, either it should override that or use the exceptionPropagationPolicy from the RetryPolicy which it takes as an argument of constructor.

Now, Let's say we are passing BasicReactiveRetryPolicy (with ExceptionPropagationPolicy as UNWRAP) while creating instance for FilteredReactiveRetryPolicy. When Retries are exhuasted, that time exceptionPropagationPolicy flag will be NONE. So, it won't unwrap the OutOfRetryException. So, we need to override the exceptionPropagationPolicy in FilteredReactiveRetryPolicy.

AmanKamani avatar Dec 30 '23 19:12 AmanKamani

@kptfh I have raised PR for this: https://github.com/PlaytikaOSS/feign-reactive/pull/658

AmanKamani avatar Dec 30 '23 19:12 AmanKamani

fixed in https://github.com/PlaytikaOSS/feign-reactive/pull/679

kptfh avatar Sep 04 '24 08:09 kptfh