plasmo icon indicating copy to clipboard operation
plasmo copied to clipboard

[BUG] Typescript Import Attributes

Open GODrums opened this issue 1 year ago • 1 comments

What happened?

Using Typescript's import attributes leads to build errors in Plasmo.

With Typescript 5.3, import attributes have been introduced: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-3.html

🟣 Plasmo v0.86.3
🔴 The Browser Extension Framework
🔵 INFO   | Starting the extension development server...
🔵 INFO   | Loaded environment variables from: [ '.env.chrome', '.env' ]
🔴 ERROR  | Build failed. To debug, run plasmo dev --verbose.
🔴 ERROR  | Expected ';', got 'with'

or with plasmo dev --verbose

🔵 INFO   | Loaded environment variables from: [ '.env.chrome', '.env' ]
🟡 0      | @plasmohq/parcel-transformer-manifest
🟡 1      | Adding tab onboarding.tsx
🟡 2      | Adding icons
🟡 3      | Adding default_icon
🟡 4      | Adding default_popup
🟡 5      | Handling MV3 background service worker
🟡 6      | + Finished transforming manifest
🔴 ERROR  | Expected ';', got 'with'
🟡 30     | ...\src\lib\handlers\mappinghandler.ts:1:45

with the corresponding line mappinghandler.ts:1:45: import buffIds from '@/assets/buffids.json' with { type: "json" };

My package.json uses "typescript": "5.4.5".

Version

Latest

What OS are you seeing the problem on?

Windows

What browsers are you seeing the problem on?

No response

Relevant log output

No response

(OPTIONAL) Contribution

  • [ ] I would like to fix this BUG via a PR

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct
  • [X] I checked the current issues for duplicate problems.

GODrums avatar Jun 01 '24 19:06 GODrums

I think the packaged Parcel's TS path resolver doesn't support TS import attributes atm xd...

If you can help with #813 that'd be great.

louisgv avatar Jun 10 '24 12:06 louisgv