PID-Analyzer icon indicating copy to clipboard operation
PID-Analyzer copied to clipboard

set default scaling equal across all noise plots

Open bw1129 opened this issue 5 years ago • 2 comments

I would really like to see default scaling set equal across all noise plots. Sometimes people upload these plots and are mislead by the fact that the post filtered gyro looks noisier than prefiltered, because the scaling is not comparable across plots. I realize the colorbar is there to help, but for practical purposes, it's rather misleading at a glance, and it is currently not possible to really make a direct clear comparison even using the colorbar. By scaling them the same, the differences in density of yellow hot spots is a true representation of the differences. Even if this results are over saturated for the pre-filtered gyro (debug) condition, this cond mainly serves as a benchmark anyway.

It only requires a small change to line 398: lims=np.array([[1, 20],[1, 20], [1, 20], [0,meanspec_max*1.5]]) I think 1 to 20 is perfect across all. I think line 398 contains the default lims. Looks like it is set to detect the max value it sees for each axis and scale accordingly. Maybe there's a better way to just create another option called "equal-scaling" and make that default, and leave the current "auto" option if someone wants to input that.

bw1129 avatar Mar 14 '19 20:03 bw1129

This is a more acceptable scale fix? If so I will delete my PR and add these changes to my own repo.

Bradw-17 avatar Mar 15 '19 17:03 Bradw-17

This is a more acceptable scale fix? If so I will delete my PR and add these changes to my own repo.

This proposal is just to fix the scales the same across all panels. You can still input any scale you want in the command window if that's what you want, but I thought you needed a change specific to Unix or Mac environment? In any case, I hope they consider it, cause it would certainly clear up a lot of confusion some people have.

bw1129 avatar Mar 15 '19 20:03 bw1129