DESC icon indicating copy to clipboard operation
DESC copied to clipboard

Add qfm surface functionality

Open dpanici opened this issue 1 year ago • 3 comments

Resolve #1162

  • [ ] add tutorial for this
  • [x] allow ToroidalFlux to accept FourierRZToroidalSurface so that we can specify the toroidal flux through the QFM (we can do the vector potential method on the surface just fine so this should be easy, and there is no plasma current to consider either)

dpanici avatar Sep 24 '24 03:09 dpanici

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.58%. Comparing base (2741269) to head (82ed185). Report is 1740 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1264   +/-   ##
=======================================
  Coverage   95.57%   95.58%           
=======================================
  Files          96       96           
  Lines       24405    24484   +79     
=======================================
+ Hits        23325    23402   +77     
- Misses       1080     1082    +2     
Files with missing lines Coverage Δ
desc/objectives/__init__.py 100.00% <ø> (ø)
desc/objectives/_coils.py 99.27% <100.00%> (+0.12%) :arrow_up:
desc/optimize/optimizer.py 97.12% <100.00%> (-0.02%) :arrow_down:

... and 2 files with indirect coverage changes

codecov[bot] avatar Sep 24 '24 03:09 codecov[bot]

|             benchmark_name             |         dt(%)          |         dt(s)          |        t_new(s)        |        t_old(s)        | 
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
 test_build_transform_fft_midres         |     +5.15 +/- 4.48     | +3.00e-02 +/- 2.61e-02 |  6.13e-01 +/- 2.3e-02  |  5.83e-01 +/- 1.3e-02  |
 test_build_transform_fft_highres        |     +2.82 +/- 2.98     | +2.65e-02 +/- 2.80e-02 |  9.66e-01 +/- 1.5e-02  |  9.40e-01 +/- 2.4e-02  |
 test_equilibrium_init_lowres            |     +0.81 +/- 4.48     | +3.03e-02 +/- 1.67e-01 |  3.76e+00 +/- 8.5e-02  |  3.73e+00 +/- 1.4e-01  |
 test_objective_compile_atf              |     +0.56 +/- 3.80     | +4.26e-02 +/- 2.89e-01 |  7.67e+00 +/- 1.2e-01  |  7.62e+00 +/- 2.6e-01  |
 test_objective_compute_atf              |     +1.38 +/- 4.29     | +1.42e-04 +/- 4.39e-04 |  1.04e-02 +/- 4.2e-04  |  1.02e-02 +/- 1.3e-04  |
 test_objective_jac_atf                  |     +1.53 +/- 4.49     | +2.81e-02 +/- 8.23e-02 |  1.86e+00 +/- 7.1e-02  |  1.83e+00 +/- 4.2e-02  |
 test_perturb_1                          |     +1.03 +/- 2.06     | +1.38e-01 +/- 2.77e-01 |  1.36e+01 +/- 1.5e-01  |  1.34e+01 +/- 2.3e-01  |
 test_proximal_jac_atf                   |     -0.03 +/- 1.67     | -2.36e-03 +/- 1.32e-01 |  7.94e+00 +/- 8.4e-02  |  7.94e+00 +/- 1.0e-01  |
 test_proximal_freeb_compute             |     -0.67 +/- 2.48     | -1.31e-03 +/- 4.86e-03 |  1.94e-01 +/- 4.8e-03  |  1.96e-01 +/- 1.0e-03  |
 test_build_transform_fft_lowres         |     +1.97 +/- 4.65     | +1.02e-02 +/- 2.41e-02 |  5.28e-01 +/- 2.3e-02  |  5.18e-01 +/- 7.7e-03  |
 test_equilibrium_init_medres            |     +0.72 +/- 1.62     | +2.97e-02 +/- 6.64e-02 |  4.13e+00 +/- 6.0e-02  |  4.10e+00 +/- 2.9e-02  |
 test_equilibrium_init_highres           |     +0.44 +/- 1.11     | +2.38e-02 +/- 5.95e-02 |  5.39e+00 +/- 4.9e-02  |  5.37e+00 +/- 3.4e-02  |
 test_objective_compile_dshape_current   |     +0.38 +/- 1.32     | +1.46e-02 +/- 5.08e-02 |  3.86e+00 +/- 3.9e-02  |  3.85e+00 +/- 3.3e-02  |
 test_objective_compute_dshape_current   |     -0.16 +/- 1.96     | -6.01e-06 +/- 7.18e-05 |  3.65e-03 +/- 4.8e-05  |  3.65e-03 +/- 5.3e-05  |
 test_objective_jac_dshape_current       |     +3.70 +/- 9.49     | +1.47e-03 +/- 3.79e-03 |  4.14e-02 +/- 2.4e-03  |  3.99e-02 +/- 2.9e-03  |
 test_perturb_2                          |     -0.42 +/- 1.65     | -7.90e-02 +/- 3.08e-01 |  1.86e+01 +/- 1.9e-01  |  1.87e+01 +/- 2.4e-01  |
 test_proximal_freeb_jac                 |     -0.06 +/- 1.14     | -4.67e-03 +/- 8.51e-02 |  7.47e+00 +/- 5.3e-02  |  7.48e+00 +/- 6.6e-02  |
 test_solve_fixed_iter                   |     +0.13 +/- 56.75    | +6.68e-03 +/- 2.88e+00 |  5.08e+00 +/- 2.1e+00  |  5.07e+00 +/- 2.0e+00  |

github-actions[bot] avatar Sep 24 '24 03:09 github-actions[bot]

make a new objective for this specifically

dpanici avatar Sep 25 '24 17:09 dpanici

update if #1205 is merged first

dpanici avatar Oct 16 '24 17:10 dpanici

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB