DESC icon indicating copy to clipboard operation
DESC copied to clipboard

Check what change in code caused the old `input.HELIOTRON` file result to change

Open dpanici opened this issue 7 months ago • 0 comments

          > Feels really weird that going from m=8 to m=9 makes such a big difference?

I also agree but this is the result I see, if the point of the notebook is to just use the automatic contiunation that by default is used when running on a vmec input file, it currently results in an equilibrium with barely any shafranov shift on master after running python -m desc input.HELIOTRON

This is fixed if we up the resolution by 1. The current saved input.HELIOTRON_output.h5 on master has L=M=8 resolution, so possibly what happened is it is from before we made the change so that when we load a VMEC input file, we set MPOL to be one less than what VMEC's MPOL is

image

Originally posted by @dpanici in https://github.com/PlasmaControl/DESC/issues/1005#issuecomment-2085737111

Things to check

  • [ ] If the continuation method steps are weird or have changed
  • [ ] if the non continuation method returns the same or not
  • [ ] if it is indeed the MPOL thing (MPOL to MPOL-1 upon loading VMEC was changed about 2 years ago, but 6 months ago we lowered the resolution from 12 to 8... so worth checking the code at that point)
  • [ ] if ANSI vs FRINGE matters here

dpanici avatar Jul 06 '24 17:07 dpanici