curriculum icon indicating copy to clipboard operation
curriculum copied to clipboard

Terms and conditions -- Hyperlink and Content missing; Casing fix

Open Preetha007 opened this issue 3 years ago • 12 comments

In SignUp page, the content "terms and conditions" missing its Hyperlink and Content; Also Casing of "T" in terms and "C" in conditions could be changed to Caps.

Steps To Reproduce

  1. Go to https://test-app.nullcast.dev/curriculum
  2. Click on Login Button, where user redirected to the Login page.
  3. Click on Sign Up Button, where user gets displayed the Sign Up form.
  4. The Checkbox contents "terms and conditions" missing its Hyperlink and Content.
  5. Also Casing of "T" in terms and "C" in conditions could be changed to Caps.

Expected behavior User when clicks on the "Terms and Conditions" hyperlink, have to redirect the user to the Terms and Conditions page. And the Casing of "T" in terms and "C" in conditions as Caps.

Recording attached* https://www.loom.com/share/0ec0d7f35c97494ca283eaad99bb1f78

Desktop (please complete the following information): ThinkPad

  • OS: Linux
  • Browser: Linux
  • Version: Version 95.0.4638.54 (Official Build) (64-bit)

Smartphone: Not Tested

Additional context Tested in Testsite

Preetha007 avatar Oct 27 '21 06:10 Preetha007

can I work on this ?

sk6298 avatar Oct 27 '21 06:10 sk6298

yeah.. you can @sk6298

thealpha93 avatar Oct 27 '21 06:10 thealpha93

Can you share route for terms and condition page ? @thealpha93

sk6298 avatar Oct 27 '21 07:10 sk6298

@sk6298 It's in the signup page https://test-app.nullcast.dev/signup

Note: we don't have the content for terms and conditions yet

thealpha93 avatar Oct 27 '21 07:10 thealpha93

@thealpha93 Sorry if I was not clear, I want to know where to redirect when user click on terms and conditions. Also can I make one pull request for #305 and #307 or should I keep them seprate ?

sk6298 avatar Oct 27 '21 07:10 sk6298

@sk6298 We haven't created the terms and conditions page yet. So no need to redirect it now. So I'm going to label this issue as help wanted. We'll work on this issue after the terms and conditions page is created

thealpha93 avatar Oct 27 '21 07:10 thealpha93

@sk6298 But you can work on #307

thealpha93 avatar Oct 27 '21 07:10 thealpha93

@sk6298 Would you like to join our discord server and collaborate directly with us?

https://discord.gg/UNqCpTAU

thealpha93 avatar Oct 27 '21 07:10 thealpha93

@thealpha93 will correct typo also in #307 then as well as css fix. Would love to join discord

sk6298 avatar Oct 27 '21 07:10 sk6298

Cool. Here's the invite link: https://discord.gg/UNqCpTAU

thealpha93 avatar Oct 27 '21 07:10 thealpha93

Corrected typo in this pull request: https://github.com/Planet-NULLCAST/curriculum/pull/310

sk6298 avatar Oct 27 '21 07:10 sk6298

Thanks @sk6298

thealpha93 avatar Oct 27 '21 07:10 thealpha93