Nick Oliver

Results 28 comments of Nick Oliver

Either way, selecting a port isn't as important as the [tasks you've outlined](https://github.com/joshmarinacci/ElectronIDE#want-to-help). We can push this off, sorry to distract. (importance level, no point in automatically selecting a port...

@og2t probably before as well, but at 9cc4e06 the situation looks highly improved: ![image](https://cloud.githubusercontent.com/assets/3945917/8061848/a8258d9c-0e81-11e5-9064-62dbd627f169.png)

@mdesantis looks like #79 fixed this: ![image](https://cloud.githubusercontent.com/assets/3945917/8061688/efa9ef4c-0e80-11e5-898b-f6a747b2fe67.png)

Can you try deploying a sample using just the base image (`registry.access.redhat.com/ubi9/nginx-122:1-45`)? :thinking: Might be useful to also try [the official nginx image](https://hub.docker.com/_/nginx) `registry.hub.docker.com/library/nginx` directly, and then (maybe :sweat_smile:) an...

I haven't attempted reproducing this yet, but FWIW https://github.com/meshtastic/firmware/pull/652 started and https://github.com/meshtastic/firmware/pull/656 added CORS support, albeit the `*` value (rather than repeating back the origin). [MDN says](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Origin#directives) this is valid...

I did have the image snapshots added ``` $ git status ... new file: tests/example.spec.ts-snapshots/Prompts-adding-a-new-connection-as-the-call-to-action-when-there-are-no-devices-1-chromium-linux.png new file: tests/example.spec.ts-snapshots/Shows-the-protocols-as-the-first-step-of-adding-a-device-1-chromium-linux.png new file: tests/example.spec.ts-snapshots/connect-over-http-chromium-linux.png new file: tests/example.spec.ts-snapshots/connect-over-serial-chromium-linux.png ``` but when pushing to my...

Before moving this PR to a ready state we might need to think through the impact of GitHub's image storage on contributions? https://github.com/meshtastic/web/pull/205#issuecomment-2118979986 I'm in the Meshtastic Discord "server" if...

I'm glad unit testing is started via #462 👍 This PR was for browser tests 😉 [insert the units tests passed meme]