Mark Collins
Mark Collins
We'll look into this at some point.
We're actively working on this, it will be fixed.
We should be reporting the values as-is to the game, any drift is on the controller's end but we could introduce a deadzone potentially.
No, it will be done at some point still. We haven't gotten a proper point to refactor due to `ftx1` having so much in flux so it'll probably be done...
We've planned this from the start, the "Emulator Menu" button in the controller mapping is unused at the moment but it's meant for this in the future. I'll leave this...
Are you talking about the emulated JoyCon or a real JoyCons that you're using as the controller for Skyline? If it's the latter then it's an issue with the kernel...
Correct, this is not really on us but there is something we may be able to do about it in the future with a custom HID driver but not anytime...
Both of these things have been planned for a while, we just haven't gotten to them. I'll leave this issue open till they're resolved.
The contribution looks fine (good job!) but I'd recommend rebasing the commit atop `ftx1` rather than `master` and following our naming convention for commits a bit more closely, a better...
@lynxnb Feel free to rebase this PR if it's good to go. I'm leaving these OSC PRs to you.