PixelGuys
Should the hotbar be separate from the inventory?
This would simplify a decent amount of code and make #2253 much easier. It would also help prevent inventory slot mappings from getting too unwieldy, especially with armor and accessories (#604)
I agree with this, would also help with pulling items from the inventory when pick-blocking with middle click (https://github.com/PixelGuys/Cubyz/issues/1990)
I also like this and will maybe today look at it if I can implement it. The Inventory code should not be that hard. What I worry about is the migration code as this should not be a breaking change where we need to tell people not to have things in the hotbar when they update. Maybe someone knows how we could do that or if we can do that. Later I will probably look into this myself.
It would make other interactions harder though, like e.g. collecting items, shift clicking into the combined inventory+hotbar.
It would make other interactions harder though, like e.g. collecting items, shift clicking into the combined inventory+hotbar.
Not significantly though, it shouldn't be too hard to just check both inventories. We could even add a setting to switch between which inventory is prioritized if we wanted to.
Well, I think it would end up being more effort than implementing shift clicking (and middle click and others) in the combined inventory system. Only way to know for sure though is to try it.
Well, I think it would end up being more effort than implementing shift clicking (and middle click and others) in the combined inventory system. Only way to know for sure though is to try it.
My main issue with this is that having the different implementations of shift clicking from a chest to your inventory vs from your hotbar might lead to inconsistencies in the future and definitely won't help readability.