OpenUSD icon indicating copy to clipboard operation
OpenUSD copied to clipboard
verified publisher icon PixarAnimationStudios

Autodesk: Text - Add the schema for MarkupText

Open erikaharrison-adsk opened this issue 1 year ago • 6 comments

Description of Change(s)

A new geometry schema MarkupText and its associated property schema ColumnLayout and ParagraphLayout were defined in pxr/usd/usdText/schema.usda. MarkupText also uses property schema TextStyle which is defined by SimpleText.

Several schemas boilerplate files were generated by calling usdGenSchema on schema.usda. Comment "Script generated file" is added to each usdGenSchema generated file to help the reviewer identify and ignore them.

Details of MarkupText and its style and layout schema were defined in the Text proposal. PR of the Text proposal can be accessed here. Feedback on the proposal is also appreciated.

There is no unit tests created in this PR since tests for MarkupText would require the implementation of SimpleText (which is in another PR). We will add the unit tests in this PR after the SimpleText is merged in dev: https://github.com/PixarAnimationStudios/OpenUSD/pull/3258

This supersedes prior https://github.com/PixarAnimationStudios/OpenUSD/pull/3002.

Fixes Issue(s)

  • N/A
  • [X] I have verified that all unit tests pass with the proposed changes
  • [X] I have submitted a signed Contributor License Agreement

erikaharrison-adsk avatar Aug 30 '24 01:08 erikaharrison-adsk

Hello! Please do not modify any generatedSchema.usda files, as it will cause some of our internal test automation to fail. I think reviewers will know to skip them.

Thank you!

On Thu, Aug 29, 2024 at 6:09 PM Erika Harrison @.***> wrote:

Description of Change(s)

A new geometry schema MarkupText and its associated property schema ColumnLayout and ParagraphLayout were defined in pxr/usd/usdText/schema.usda. MarkupText also uses property schema TextStyle which is defined by SimpleText.

Several schemas boilerplate files were generated by calling usdGenSchema on schema.usda. Comment "Script generated file" is added to each usdGenSchema generated file to help the reviewer identify and ignore them.

Details of MarkupText and its style and layout schema were defined in the Text proposal https://github.com/PixarAnimationStudios/OpenUSD-proposals/blob/main/proposals/text/README.md . PR of the Text proposal can be accessed here https://github.com/PixarAnimationStudios/OpenUSD-proposals/pull/24. Feedback on the proposal is also appreciated.

There is no unit tests created in this PR since tests for MarkupText would require the implementation of SimpleText (which is in another PR). We will add the unit tests in this PR after the SimpleText is merged in dev: #3258 https://github.com/PixarAnimationStudios/OpenUSD/pull/3258

This supersedes prior #3002 https://github.com/PixarAnimationStudios/OpenUSD/pull/3002. Fixes Issue(s)

  • N/A

  • I have verified that all unit tests pass with the proposed changes

  • I have submitted a signed Contributor License Agreement

You can view, comment on, or merge this pull request online at:

https://github.com/PixarAnimationStudios/OpenUSD/pull/3259 Commit Summary

File Changes

(31 files https://github.com/PixarAnimationStudios/OpenUSD/pull/3259/files)

Patch Links:

  • https://github.com/PixarAnimationStudios/OpenUSD/pull/3259.patch
  • https://github.com/PixarAnimationStudios/OpenUSD/pull/3259.diff

— Reply to this email directly, view it on GitHub https://github.com/PixarAnimationStudios/OpenUSD/pull/3259, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPOU2BS7ZGCWSWLHTN6OPTZT7A5TAVCNFSM6AAAAABNLP5UTSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ4TKOJSGQ3DCMY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

spiffmon avatar Aug 30 '24 05:08 spiffmon

That goes for all generated files, actually, except inside the “Custom” sections.

On Thu, Aug 29, 2024 at 6:09 PM Erika Harrison @.***> wrote:

Description of Change(s)

A new geometry schema MarkupText and its associated property schema ColumnLayout and ParagraphLayout were defined in pxr/usd/usdText/schema.usda. MarkupText also uses property schema TextStyle which is defined by SimpleText.

Several schemas boilerplate files were generated by calling usdGenSchema on schema.usda. Comment "Script generated file" is added to each usdGenSchema generated file to help the reviewer identify and ignore them.

Details of MarkupText and its style and layout schema were defined in the Text proposal https://github.com/PixarAnimationStudios/OpenUSD-proposals/blob/main/proposals/text/README.md . PR of the Text proposal can be accessed here https://github.com/PixarAnimationStudios/OpenUSD-proposals/pull/24. Feedback on the proposal is also appreciated.

There is no unit tests created in this PR since tests for MarkupText would require the implementation of SimpleText (which is in another PR). We will add the unit tests in this PR after the SimpleText is merged in dev: #3258 https://github.com/PixarAnimationStudios/OpenUSD/pull/3258

This supersedes prior #3002 https://github.com/PixarAnimationStudios/OpenUSD/pull/3002. Fixes Issue(s)

  • N/A

  • I have verified that all unit tests pass with the proposed changes

  • I have submitted a signed Contributor License Agreement

You can view, comment on, or merge this pull request online at:

https://github.com/PixarAnimationStudios/OpenUSD/pull/3259 Commit Summary

File Changes

(31 files https://github.com/PixarAnimationStudios/OpenUSD/pull/3259/files)

Patch Links:

  • https://github.com/PixarAnimationStudios/OpenUSD/pull/3259.patch
  • https://github.com/PixarAnimationStudios/OpenUSD/pull/3259.diff

— Reply to this email directly, view it on GitHub https://github.com/PixarAnimationStudios/OpenUSD/pull/3259, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPOU2BS7ZGCWSWLHTN6OPTZT7A5TAVCNFSM6AAAAABNLP5UTSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ4TKOJSGQ3DCMY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

spiffmon avatar Aug 30 '24 05:08 spiffmon

And finally realized “comment” meant GitHub comment, not source file comment. Sorry for the noise!

spiffmon avatar Aug 30 '24 05:08 spiffmon

Filed as internal issue #USD-10050

jesschimein avatar Sep 03 '24 15:09 jesschimein

/AzurePipelines run

jesschimein avatar Sep 03 '24 15:09 jesschimein

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 03 '24 15:09 azure-pipelines[bot]