OpenUSD icon indicating copy to clipboard operation
OpenUSD copied to clipboard

Autodesk: [build_usd.py, hioAvif] Add option to build with AVIF

Open erikaharrison-adsk opened this issue 1 year ago • 3 comments

Description of Change(s)

  • Add --avif and --no-avif options to build_usd.py

Fixes Issue(s)

  • N/A
  • [X] I have verified that all unit tests pass with the proposed changes
  • [X] I have submitted a signed Contributor License Agreement

erikaharrison-adsk avatar Aug 14 '24 15:08 erikaharrison-adsk

Filed as internal issue #USD-9980

jesschimein avatar Aug 14 '24 18:08 jesschimein

/AzurePipelines run

jesschimein avatar Aug 14 '24 18:08 jesschimein

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 14 '24 18:08 azure-pipelines[bot]

Hi @erikaharrison-adsk , we appreciate the bugfix in CMakeLists.txt, which we will make, but we don't see any compelling reason for the additional build_usd options, given the almost trivial cost of building our interned AVIF, and that other hio plugins are free to override it in plugin priority?

spiffmon avatar May 13 '25 00:05 spiffmon

Hello @spiffmon . The change was in the context of WASM, since it wasn't supported and there was no way to programatically disable it. We might want to close this PR, since now we are in the process of discussing all wasm changes directly with some other folks at PIXAR

kohakukun avatar May 16 '25 09:05 kohakukun

OK, thanks, @erikaharrison-adsk - closing for now!

spiffmon avatar May 17 '25 01:05 spiffmon