OpenUSD icon indicating copy to clipboard operation
OpenUSD copied to clipboard
verified publisher icon PixarAnimationStudios

feat: add validator SkelBindingAPIAppliedChecker

Open beersandrew opened this issue 1 year ago • 8 comments

Description of Change(s)

add validator SkelBindingAPIAppliedChecker

  • added a validation check for when a skel binding property is present but the skel binding api is not applied
  • added a validation check for when a skel binding api is applied to a prim that is not parented by a skel root
  • added a unit test

Fixes Issue(s)

  • https://github.com/orgs/PixarAnimationStudios/projects/3/views/1?pane=issue&itemId=65425045
  • [X] I have verified that all unit tests pass with the proposed changes
  • [X] I have submitted a signed Contributor License Agreement

beersandrew avatar Jul 15 '24 19:07 beersandrew

Filed as internal issue #USD-9849

jesschimein avatar Jul 16 '24 16:07 jesschimein

/AzurePipelines run

jesschimein avatar Jul 16 '24 16:07 jesschimein

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jul 16 '24 16:07 azure-pipelines[bot]

LGTM! other than a couple small notes, most of which are just minor style ones.

dgovil avatar Jul 16 '24 21:07 dgovil

LGTM! other than a couple small notes, most of which are just minor style ones.

Made the suggested changes. Thanks so much for the review & ideas.

beersandrew avatar Jul 16 '24 21:07 beersandrew

Just curious why is this a draft PR?

tallytalwar avatar Jul 17 '24 06:07 tallytalwar

/AzurePipelines run

jesschimein avatar Jul 18 '24 19:07 jesschimein

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jul 18 '24 19:07 azure-pipelines[bot]