OpenUSD icon indicating copy to clipboard operation
OpenUSD copied to clipboard

Apple: Remove HDF5 support

Open dgovil opened this issue 1 year ago • 5 comments

Description of Change(s)

This PR consists of two commits. One that removes HDF5 support from the build_usd.py, and the other that removes it from the USD codebase as a whole.

I split it into two commits so it may ease the ability to pick the level of support you want to leave in. However, I would perhaps suggest removing HDF5 altogether if nobody has objections, as I worry the code will just eventually bit rot, if it hasn't already.

Fixes Issue(s)

  • https://github.com/PixarAnimationStudios/OpenUSD/issues/3156
  • [X] I have verified that all unit tests pass with the proposed changes
  • [X] I have submitted a signed Contributor License Agreement

dgovil avatar Jul 15 '24 18:07 dgovil

@marktucker , @crydalch -- does Houdini still need HDF5 Alembic support? Thanks! https://www.sidefx.com/docs/houdini/nodes/out/alembic.html

asluk avatar Jul 15 '24 23:07 asluk

Filed as internal issue #USD-9848

jesschimein avatar Jul 16 '24 16:07 jesschimein

/AzurePipelines run

jesschimein avatar Jul 16 '24 16:07 jesschimein

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jul 16 '24 16:07 azure-pipelines[bot]

We are reluctant to drop support for reading HDF5 Alembics without a strong reason. We don't want to make any unnecessary assumptions about what kind of legacy data or tools our customers may be using.

So SideFX will continue to support HDF5 Alembic loading in USD as long as we support it in Houdini proper. And although this discussion has triggered us to think more about our position moving forward, we need to support reading of HDF5 Alembics for at least the next version or two of Houdini (to allow for a period of safe/orderly/officially announced deprecation).

So from our perspective it would be great if at least the C++ code in alembicReader.cpp could be left alone, with whatever compile guards the community may consider appropriate. We don't use the build_usd.py script, and already build our own Alembic and HDF5 libraries, so we have no problem with the removal of HDF5 as an option there.

The benefit of leaving the C++ code in place is simply to minimize differences from our fork of USD to the Pixar standard fork. If HDF5 support is officially removed from the Pixar fork, we'll just add the required code back into our own fork and accept responsibility for maintaining this bit of the code for our customers.

marktucker avatar Jul 16 '24 18:07 marktucker