OpenUSD icon indicating copy to clipboard operation
OpenUSD copied to clipboard

Apple : Compilation support for MaterialX 1.38.X and 1.39.X

Open ld-kerley opened this issue 1 year ago • 6 comments

Description of Change(s)

MaterialX 1.39.X introduced API changes, this PR allows OpenUSD to be built against either MaterialX 1.38.X or 1.39.X.

Most of the changed arise from an API change around MaterialX::TypeDesc being passed by value instead of pointer. The other change is the complete removal of the channels attribute.

NOTE : The MaterialX versioning PR (#3157) should be merged before this.

Fixes Issue(s)

Fixes compile issues when using MaterialX 1.39.X

  • [ ] I have verified that all unit tests pass with the proposed changes
  • [X] I have submitted a signed Contributor License Agreement

ld-kerley avatar Jul 10 '24 22:07 ld-kerley

Filed as internal issue #USD-9837

:heavy_exclamation_mark: Please make sure that a signed CLA has been submitted!

jesschimein avatar Jul 11 '24 16:07 jesschimein

/AzurePipelines run

jesschimein avatar Jul 11 '24 16:07 jesschimein

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jul 11 '24 16:07 azure-pipelines[bot]

/AzurePipelines run

jesschimein avatar Sep 05 '24 23:09 jesschimein

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 05 '24 23:09 azure-pipelines[bot]

May you please rebase materialXFilter.cpp ?

zwillikon avatar Sep 14 '24 17:09 zwillikon

bump :p

nyabinary avatar Nov 03 '24 21:11 nyabinary

/AzurePipelines run

jesschimein avatar Nov 04 '24 16:11 jesschimein

Pull request contains merge conflicts.

azure-pipelines[bot] avatar Nov 04 '24 16:11 azure-pipelines[bot]