OpenUSD icon indicating copy to clipboard operation
OpenUSD copied to clipboard

PEGTL USDA Parser

Open erslavin opened this issue 1 year ago • 19 comments

  • Added additional text file format parser based on PEGTL
  • Added tests specific to PEGTL parser
  • Removed lex / yacc based parser

Description of Change(s)

This change introduces a new sdf / usda text file format paser based on PEGTL. This change aligns the way text file scene descriptions are parsed with the way paths are now being parsed and removes the need for a dependency on lex / yacc.

Added PEGTL Text File Format Parser Added tests specific to PEGTL parser that allow testing of partial scene description rules

Fixes Issue(s)

  • [X] I have verified that all unit tests pass with the proposed changes
  • [X] I have submitted a signed Contributor License Agreement

erslavin avatar Mar 16 '24 02:03 erslavin

Conflicts will be resolved next week 🙏🏼

asluk avatar Mar 16 '24 02:03 asluk

Filed as internal issue #USD-9462

:heavy_exclamation_mark: Please make sure that a signed CLA has been submitted!

jesschimein avatar Mar 19 '24 20:03 jesschimein

/AzurePipelines run

jesschimein avatar Mar 19 '24 20:03 jesschimein

Pull request contains merge conflicts.

azure-pipelines[bot] avatar Mar 19 '24 20:03 azure-pipelines[bot]

Please disregard the missing CLA comment -- we have it on file!

jesschimein avatar Mar 21 '24 22:03 jesschimein

/AzurePipelines run

jesschimein avatar Mar 23 '24 21:03 jesschimein

Pull request contains merge conflicts.

azure-pipelines[bot] avatar Mar 23 '24 21:03 azure-pipelines[bot]

/AzurePipelines run

jesschimein avatar Mar 25 '24 17:03 jesschimein

Pull request contains merge conflicts.

azure-pipelines[bot] avatar Mar 25 '24 17:03 azure-pipelines[bot]

/AzurePipelines run

jesschimein avatar Mar 27 '24 16:03 jesschimein

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 27 '24 16:03 azure-pipelines[bot]

There's a bug right now and the parser won't handle CPP Multiline comments not separated by whitespace. We'll update the pull request when a fix has been pushed and include a test to cover this case.

/*HELLO*//*WORLD*/

nvmkuruc avatar Apr 03 '24 14:04 nvmkuruc

/AzurePipelines run

jesschimein avatar Apr 23 '24 17:04 jesschimein

Pull request contains merge conflicts.

azure-pipelines[bot] avatar Apr 23 '24 17:04 azure-pipelines[bot]

/AzurePipelines run

jesschimein avatar Apr 25 '24 16:04 jesschimein

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Apr 25 '24 16:04 azure-pipelines[bot]

/AzurePipelines run

jesschimein avatar May 28 '24 20:05 jesschimein

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar May 28 '24 20:05 azure-pipelines[bot]

Just noting that, I have internally resolved the conflict which occurred with a38c32c66a8b3e920e7fe0d13d1d3b3879a67f88 change, so don't worry about rebasing this PR :D.

tallytalwar avatar Jun 28 '24 22:06 tallytalwar