OpenUSD icon indicating copy to clipboard operation
OpenUSD copied to clipboard

APPLE: Protect IBL convolution from NaNs in textures

Open creijon opened this issue 1 year ago • 3 comments

Description of Change(s)

On Apple platforms with the Metal port of Storm, any NaNs in the input dome light textures will propagate through the IBL convolution calculation and cause completely black lighting. on these channels.

This doesn't seem to be a problem with openGL, but it's a small change that shouldn't have a performance hit.

Fixes Issue(s)

  • Incorrect lighting when NaNs are present in input texture to dome lights.
  • [X] I have verified that all unit tests pass with the proposed changes
  • [X] I have submitted a signed Contributor License Agreement

creijon avatar Apr 07 '23 16:04 creijon

Filed as internal issue #USD-8218

sunyab avatar Apr 10 '23 22:04 sunyab

/AzurePipelines run

jesschimein avatar Apr 04 '24 16:04 jesschimein

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Apr 04 '24 16:04 azure-pipelines[bot]