OpenSubdiv icon indicating copy to clipboard operation
OpenSubdiv copied to clipboard

device-patchcoord container in osd note/warning in code - still relevant ?

Open nyue opened this issue 1 year ago • 1 comments

Is the following comment still something we need to take note of ?

https://github.com/PixarAnimationStudios/OpenSubdiv/blob/release/examples/glEvalLimit/glEvalLimit.cpp#L258

I am unsure what it is referring to.

nyue avatar Aug 22 '24 01:08 nyue

IIRC the motivation for that comment is that an array of 20-byte elements (5-ints per element) is going to lead to inefficient memory access. This will be true regardless of whether the data fetch is by the Input Assembler from a vertex buffer or via direct access from a GPU buffer.

I think it would be okay to remove that comment, and we will take that into account as we're updating the example code.

davidgyu avatar Sep 11 '24 00:09 davidgyu

Filed as internal issue #OSD-456

davidgyu avatar Apr 03 '25 13:04 davidgyu

Fixed by #1362

davidgyu avatar Jun 14 '25 01:06 davidgyu