plugin-SiteMigration icon indicating copy to clipboard operation
plugin-SiteMigration copied to clipboard

Published 20 hours ago • verified publisher icon PiwikPRO

Bugfix: invalid mapping action entries in the new site

Open Undergrounder opened this issue 10 years ago • 2 comments

Many of the action entries are invalid on the new site, when the old id is -1, 0 or null.

It can be reproduced in the integration tests that folow up this change (It has no sense to merge failling integration tests...).

I have seen, that some tests have failed. I will try to fix them the next week.

Undergrounder avatar Sep 24 '15 10:09 Undergrounder

Hi @Undergrounder Thanks for the PR!

It can be reproduced in the tests.

Where could you see this bug in the tests? the build seems to pass, but maybe tests are not covering this use case? https://travis-ci.org/PiwikPRO/plugin-SiteMigration/jobs/81562722 - Maybe you could add some tests for it?

mattab avatar Oct 06 '15 02:10 mattab

Updated. It could be reproduced in the integration tests that follow up this change. I have now added some unit tests for this use case.

Undergrounder avatar Oct 06 '15 09:10 Undergrounder