android_bootable_recovery icon indicating copy to clipboard operation
android_bootable_recovery copied to clipboard

[Feature Request]

Open sundaqiang opened this issue 3 years ago • 8 comments

PBRP has the ability to modify codename, can you add a tool to modify more read-only attributes? Many official upgrade packages now recognize more than Just Codename. This feature can be adapted to more similar models using a PBRP image.

sundaqiang avatar Oct 17 '21 11:10 sundaqiang

Hmmm, sounds good that can be implemented. Can you plz elaborate about the variables which needed more.

AndroiableDroid avatar Oct 17 '21 11:10 AndroiableDroid

@AndroiableDroid Like build fingerprint and few other device specific props

hraj9258 avatar Oct 17 '21 11:10 hraj9258

Hmmm, sounds good that can be implemented. Can you plz elaborate about the variables which needed more.

ro.separate.soft ro.product.device ro.product.system.model

There will be a lot, I think we can do something like Mprop(https://github.com/jedy/mprop, you can use this tool in the normal system, but can't use in PBRP) such a command-line tool, so that we can in the rc file to perform a custom sh, get the original system and write PBRP attribute.

Many models of the same CPU and the same manufacturer can use the same PBRP image.If you can write the properties of the original system to PBRP after startup, you can save a lot of work.Of course, attributes can vary from vendor to vendor, so a command-line tool that lets developers read and write attributes is most appropriate.

sundaqiang avatar Oct 17 '21 12:10 sundaqiang

Hmmm, sounds good that can be implemented. Can you plz elaborate about the variables which needed more.

ro.separate.soft ro.product.device ro.product.system.model

There will be a lot, I think we can do something like Mprop(https://github.com/jedy/mprop, you can use this tool in the normal system, but can't use in PBRP) such a command-line tool, so that we can in the rc file to perform a custom sh, get the original system and write PBRP attribute.

Many models of the same CPU and the same manufacturer can use the same PBRP image.If you can write the properties of the original system to PBRP after startup, you can save a lot of work.Of course, attributes can vary from vendor to vendor, so a command-line tool that lets developers read and write attributes is most appropriate.

Does resetprop not work like that?

AndroiableDroid avatar Oct 17 '21 12:10 AndroiableDroid

Hmmm, sounds good that can be implemented. Can you plz elaborate about the variables which needed more.

ro.separate.soft ro.product.device ro.product.system.model There will be a lot, I think we can do something like Mprop(https://github.com/jedy/mprop, you can use this tool in the normal system, but can't use in PBRP) such a command-line tool, so that we can in the rc file to perform a custom sh, get the original system and write PBRP attribute. Many models of the same CPU and the same manufacturer can use the same PBRP image.If you can write the properties of the original system to PBRP after startup, you can save a lot of work.Of course, attributes can vary from vendor to vendor, so a command-line tool that lets developers read and write attributes is most appropriate.

Does resetprop not work like that?

Thank you very much, I found this tool, but for example, after I modify this property (resetProp ro.product.device XXX), the about page of PBRP will not be updated, how should I deal with this?

sundaqiang avatar Oct 17 '21 13:10 sundaqiang

Ya that could be figure out. Resetprop working fone for you?

AndroiableDroid avatar Oct 17 '21 14:10 AndroiableDroid

Useful, but does not update information about the page in real time

sundaqiang avatar Oct 17 '21 14:10 sundaqiang

Ya that could be figure out. Resetprop working fone for you?

Thanks, I've taken care of my thoughts!

sundaqiang avatar Oct 19 '21 09:10 sundaqiang