Pirulax

Results 147 comments of Pirulax

Okay, so I've tried it, but they dont seem to have collisions by default.. Please provide me a custom model if you have used one on it. It makes sense...

They're elements, and I did add `setCollisionsEnabled` with 2 lines of code, but after testing it I realized weapons have no collisions by default. Thats why I said please provide...

> Reinstate file recovery code in `Shared/XML/CXMLFileImpl.cpp` What kind of 'file recovery code'. Wheres that? I'd like to refactor the whole xml file impl.cpp to use smart pointers, and shit.

Well, the only possible buffer overflow I can see here is the `name[24]` in CFileLoader. `GetNameAndDamage` might try to write more than 24 characters into the buffer, which, obviously, triggers...

If someone would be kind enough to merge that PR the issue would be fixed right away. (In another PR the buffer size could be increased as well)

Also, that buffer should be sufficient. First the node name plugin's buffer size should be increased.

That just seems to be Z fighting, which yes, is most likely why they were higher off the ground originally. I guess not much can be done about it, but...

Most people aren't knowledgeable enough to figure out this causes the issue, and I'm pretty sure most of them find this annoying when it happens, so I stand by my...

Fail.. I totally forgot about me pushing the commit, and I soft reseted.. nvm...

Yes indeed, it is. Good idea, not sure why I didnt do it that way.