piranha.core icon indicating copy to clipboard operation
piranha.core copied to clipboard

Upgrade TinyMCE to 6.7.0?

Open hellfirehd opened this issue 9 months ago • 2 comments

Are there any plans to upgrade TinyMCE to v6.7.0?

In my own experimenting, It looks like the piranhaimage and piranhalink plugins will work without any modifications. The only significant changes are to:

  • _EditorConfig.cshtml - supply an array instead of a string:
- this.plugins = "@EditorConfig.Current.Plugins";
+ this.plugins = @EditorConfig.Current.Plugins();
  • An extension method to convert editorconfig.json plugins to an array:
public static IHtmlContent Plugins(this EditorConfig config)
{
  var plugins = config.Plugins.Split(' ', StringSplitOptions.TrimEntries | StringSplitOptions.RemoveEmptyEntries);
  return new HtmlContentBuilder().AppendHtml(JsonConvert.SerializeObject(plugins));
}

Also, TinyMCE v6.7.0 no longer includes jquery.tinymce.min.js but this does not appear to be used by PiranhaCMS.

Thoughts?

hellfirehd avatar Oct 12 '23 18:10 hellfirehd