pipedream icon indicating copy to clipboard operation
pipedream copied to clipboard

Google calendar: Add ability to send updates

Open markwoodward23 opened this issue 1 year ago • 10 comments

Adds support for sending invitees notifications when they are invited to a calendar invite, as per https://developers.google.com/calendar/api/v3/reference/events/insert ( || false is to cater for it defaulting to false - as per docs)

markwoodward23 avatar Jul 22 '22 16:07 markwoodward23

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
pipedream-docs ✅ Ready (Inspect) Visit Preview Jul 25, 2022 at 7:18PM (UTC)
pipedream-docs-redirect-do-not-edit ✅ Ready (Inspect) Visit Preview Jul 25, 2022 at 7:18PM (UTC)

vercel[bot] avatar Jul 22 '22 16:07 vercel[bot]

Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified.

dylburger avatar Jul 22 '22 16:07 dylburger

Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:

dylburger avatar Jul 22 '22 16:07 dylburger

Should be passing now @lcaresia

markwoodward23 avatar Jul 22 '22 23:07 markwoodward23

@markwoodward23 @lcaresia Observing following issues after QA verification.

  1. Event creation notifications are not sent to guests when sendUpdates=all

  2. Send Updates parameter should be defined as an Optional parameter image

  3. Show the acceptable values for Send Updates for the user "all": Notifications are sent to all guests. "externalOnly": Notifications are sent to non-Google Calendar guests only. "none": No notifications are sent.

DilanAthukorala avatar Jul 25 '22 03:07 DilanAthukorala

@DilanAthukorala - how can I run this locally to debug/use a deployed version? I can't find any instructions in the contributing guide.

@markwoodward23 You can use pd publish to locally deploy components and test find the documentation here - https://pipedream.com/docs/cli/reference/#pd-publish https://pipedream.com/docs/cli/install/#macos

DilanAthukorala avatar Jul 25 '22 14:07 DilanAthukorala

Thanks @DilanAthukorala - found the quickstart guide, I think it'd be useful to link this from contributing or the readme - I'll follow up with a PR for that. Realised I was passing the parameter in the wrong place, corrected this and verified it works.

markwoodward23 avatar Jul 25 '22 19:07 markwoodward23

@lcaresia is this back to you for review?

markwoodward23 avatar Jul 27 '22 13:07 markwoodward23

Hello @markwoodward23, I have moved your PR to Ready for PR review stage and it will be reviewed soon. Thank you for your patient and contribution 🙏

vunguyenhung avatar Jul 28 '22 15:07 vunguyenhung

Thanks @jcortes and @vunguyenhung!

markwoodward23 avatar Jul 30 '22 18:07 markwoodward23