pipedream
pipedream copied to clipboard
Add Verifalia actions
Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:
- [ ] Create components to address specific use cases whenever possible
- [ ] Component
key
s should follow the formatapp_name_slug-slugified-component-name
- [ ] Components should follow the standard directory structure
- [ ] Prefer Node.js client libraries to REST APIs
- [ ] When making API requests, handle pagination to ensure all data / events are processed
- [ ] Use
secret
props to capture sensitive data - [ ] Props and methods should be defined in app files whenever possible
- [ ] Document methods with JS Docs
- [ ] Use
optional
props whenever possible, and set adefault
value where you can - [ ] Use async options to accept user input wherever possible
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
pipedream-docs | ✅ Ready (Inspect) | Visit Preview | Sep 1, 2022 at 4:48PM (UTC) |
pipedream-docs-redirect-do-not-edit | ✅ Ready (Inspect) | Visit Preview | Sep 1, 2022 at 4:48PM (UTC) |
Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified.
Hi @Hassan-Abbas-SQA & @vunguyenhung , is there any specific reason why you have moved this PR from QA back to Ready for QA? Is there anything I can do to help moving forward with this?
Many thanks!
@ecobisi i was signing off so i thought someone else would pick it up
Hello @ecobisi, I have tested this PR and there're some test cases failed or needed improvement.
Please check the test report below for more information Verifalia_3478.pdf
Hello @ecobisi, do you want our component dev to take over or you want to finish it?
Hi @vunguyenhung, I have been out of office for some days, sorry: I will take care of this myself as soon as I can - thank you!
Hello @ecobisi, no worry! I'm just checking in. Thank you so much for your contribution 🙏!
Thanks again, @vunguyenhung.
- I have fixed
get-balance
as per your kind request. - To test
delete-job
, you can also pass theoverview.id
value returned byverify-email
. - Your account has been activated twice, this is the reason why you were seeing that error message on our clients area: should you have it still open on your browser, please log out (link in the top right) / log in again.
Thank you!
/approve
Hello @lcaresia, would you mind reviewing this PR again. I have tested and it passed all test cases 🙏
Hello @ecobisi, would you mind address the changes requested by @lcaresia? After that I think we can release, no need to re-test again
Thanks @vunguyenhung - I have accepted most of the suggestions from @lcaresia and am now waiting for the resolution / feedback of the ones I don't agree with.
@ecobisi agreed and approved! Merging now
Looks like the components were successfully published by CI - can you check on your end to make sure they look good?
Everything looks great, thanks @dylburger! I have just filed a separate issue for the only minor UI annoyance I have found - #3917