pipedream icon indicating copy to clipboard operation
pipedream copied to clipboard

Add Verifalia actions

Open ecobisi opened this issue 2 years ago • 10 comments

This PR adds these new actions to the Verifalia app:

  • delete-job
  • get-balance

Thank you

ecobisi avatar Jul 19 '22 17:07 ecobisi

Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:

dylburger avatar Jul 19 '22 17:07 dylburger

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
pipedream-docs ✅ Ready (Inspect) Visit Preview Sep 1, 2022 at 4:48PM (UTC)
pipedream-docs-redirect-do-not-edit ✅ Ready (Inspect) Visit Preview Sep 1, 2022 at 4:48PM (UTC)

vercel[bot] avatar Jul 19 '22 17:07 vercel[bot]

Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified.

dylburger avatar Jul 19 '22 17:07 dylburger

Hi @Hassan-Abbas-SQA & @vunguyenhung , is there any specific reason why you have moved this PR from QA back to Ready for QA? Is there anything I can do to help moving forward with this?

Many thanks!

ecobisi avatar Jul 22 '22 16:07 ecobisi

@ecobisi i was signing off so i thought someone else would pick it up

ghost avatar Jul 22 '22 19:07 ghost

Hello @ecobisi, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information Verifalia_3478.pdf

vunguyenhung avatar Jul 25 '22 05:07 vunguyenhung

Hello @ecobisi, do you want our component dev to take over or you want to finish it?

vunguyenhung avatar Jul 28 '22 14:07 vunguyenhung

Hi @vunguyenhung, I have been out of office for some days, sorry: I will take care of this myself as soon as I can - thank you!

ecobisi avatar Jul 29 '22 13:07 ecobisi

Hello @ecobisi, no worry! I'm just checking in. Thank you so much for your contribution 🙏!

vunguyenhung avatar Jul 29 '22 13:07 vunguyenhung

Thanks again, @vunguyenhung.

  • I have fixed get-balance as per your kind request.
  • To test delete-job, you can also pass the overview.id value returned by verify-email.
  • Your account has been activated twice, this is the reason why you were seeing that error message on our clients area: should you have it still open on your browser, please log out (link in the top right) / log in again.

Thank you!

ecobisi avatar Jul 30 '22 09:07 ecobisi

Hi everyone, all test cases are passed! Ready for release!

Test report Verifalia_3478_1539.pdf

vunguyenhung avatar Aug 01 '22 08:08 vunguyenhung

/approve

vunguyenhung avatar Aug 01 '22 08:08 vunguyenhung

Hello @lcaresia, would you mind reviewing this PR again. I have tested and it passed all test cases 🙏

vunguyenhung avatar Aug 01 '22 14:08 vunguyenhung

Hello @ecobisi, would you mind address the changes requested by @lcaresia? After that I think we can release, no need to re-test again

vunguyenhung avatar Aug 01 '22 14:08 vunguyenhung

Thanks @vunguyenhung - I have accepted most of the suggestions from @lcaresia and am now waiting for the resolution / feedback of the ones I don't agree with.

ecobisi avatar Aug 01 '22 16:08 ecobisi

@ecobisi agreed and approved! Merging now

dylburger avatar Aug 01 '22 16:08 dylburger

Looks like the components were successfully published by CI - can you check on your end to make sure they look good?

dylburger avatar Aug 01 '22 17:08 dylburger

Everything looks great, thanks @dylburger! I have just filed a separate issue for the only minor UI annoyance I have found - #3917

ecobisi avatar Aug 01 '22 17:08 ecobisi