pipedream icon indicating copy to clipboard operation
pipedream copied to clipboard

refactor(slack): move common props to common/send-message and remove superfluous fields

Open joscha opened this issue 1 year ago • 3 comments

WHY

Currently, there are some common props that are duplicated in all Slack components that send messages in any way (direct messages, group messages, private messages, thread responses, etc.

This pull request moves the two new properties introduced in #12003 to the common props. It also removes duplicated properties already defined in the common props that are splatted into each of the components depending on it.

cc @michelle0927

joscha avatar May 21 '24 21:05 joscha

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 6:22am
pipedream-docs-redirect-do-not-edit ⬜️ Ignored (Inspect) May 22, 2024 6:22am

vercel[bot] avatar May 21 '24 21:05 vercel[bot]

Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified.

Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:

@vunguyenhung 👋 is there anything left to do for me on this pull request?

joscha avatar May 23 '24 13:05 joscha

Hey @joscha, nothing else! This should be good to release!

vunguyenhung avatar May 23 '24 13:05 vunguyenhung

Hi everyone, all test cases are passed! Ready for release!

Test report https://vunguyenhung.notion.site/refactor-slack-move-common-props-to-common-send-message-and-remove-superfluous-fields-12018-ebbf5baadbce4c00a5a5cd7fb3611d05

vunguyenhung avatar May 23 '24 13:05 vunguyenhung