StreamCompanion icon indicating copy to clipboard operation
StreamCompanion copied to clipboard

Allow changing the mod names used [feature req.] + change default mod names for consistency

Open Starwort opened this issue 6 years ago • 8 comments

i.e. The standard modset is DT, HD, HR, HT. Kx, NC, NF, PF, RN, RX, RX2, SD, SO, TP. I would like to rename RX to AP (as the mod it represents is autopilot) and RX2 to RL (which is my preference on the abbreviation); however, this appears to be impossible. Could this be added as a feature? (For both mod image names and !mods! output)

Thank you for reading, Starwort

Starwort avatar May 06 '18 14:05 Starwort

This surely could be added. It requires collection manager mod parser class to expose functions for changing these and on SC side just some way to save and restore it.

I'll look into it after finishing initial pass of ingame overlay implementation

Piotrekol avatar May 06 '18 15:05 Piotrekol

Thank you! (And thanks for the quick response, too!)

Actually, one more thing: RX actually does refer to relax, though the mod icon that comes with SC shows AP, RX2 shows RL. This should probably be fixed (shouldn't be hard either, just renaming the assets). Auto is AP for some reason also... Basically it looks like your mods are messed up Will comment again after experimenting.

Starwort avatar May 06 '18 17:05 Starwort

All mods and any mistakes. (abbreviation) - taken from the wiki, [abbreviation] - not on the wiki. osu!std: Easy (EZ) - Correct! NoFail (NF) - Correct! Half Time (HT) - Correct! Hard Rock (HR) - Correct! Sudden Death (SD) - Correct! Perfect (PF) - Correct! SD is shown with PF - only PF should be shown Double Time (DT) - Correct! Nightcore (NC) - Correct! DT is not shown with NC - Correct! Hidden (HD) - Correct! Flashlight (FL) - Correct! Relax (RL) -> RX [but mod icon included is named "RX2"] Autopilot (AP) -> RX2 [but mod icon included is "RX"] Spun Out (SO) - Correct! Auto (AU) -> AP Cinema [CN] -> LM AU is shown with CN - only CN should be shown ScoreV2 [SV2] -> Not detected Target Practice (TP) - Correct! osu!mania: Fade In (FI) - Correct! x Keys (xK) -> Kx Co-Op [CO] -> Coop Random (RD) -> RN

I hope these can be fixed to be more consistent with the wiki :D

Starwort avatar May 06 '18 18:05 Starwort

If you want to you could submit PR to CollectionManager repo with necessary changes for these mod names, If not I'll get to that later too. All of these are defined(Except for missing ones with can be simply added there) in 2 files: ModParser.cs Mods.cs

Piotrekol avatar May 06 '18 18:05 Piotrekol

IIRC NV isn't a mod any more, it's now touch device.

Starwort avatar May 07 '18 09:05 Starwort

With these fixes in place, is this request still valid? (Would you still change any of the mods because of "preference"?)

Piotrekol avatar May 10 '18 18:05 Piotrekol

I, personally, likely would not. I do, however, feel like this would be a good future feature if you have the time (sorry for late response, push notifications are not working correctly with GMail atm). Thank you for taking the time to implement the fix.

Starwort avatar May 12 '18 09:05 Starwort

confirming that scorev2 isn't displaying in StreamCompanion v181221.22, here I was able to put together default mod icons.

Images.zip EDIT1: oops, rename RN to RD plz

h3oCharles avatar Dec 23 '18 10:12 h3oCharles