Piotr Sikora

Results 215 comments of Piotr Sikora

@andresmargalef this looks great, but I'm wondering what's the motivation behind this change? Does this result in measurable performance changes in your plugins?

I don't see any loop in your logs, the `context_id` is clearly different across those log entries. The problem with your code is that the key-value store is global, not...

> The C++ SDK logs messages [...] I'm sure you'll find many discrepancies between existing SDKs, since they were developed by different people. What's the real goal and motivation behind...

There is no such limit in either this SDK or any of the host implementations that I know of.

The limit you've linked to refers to the HTTP/2 METADATA frame size (see the document name). AFAIK, it's unrelated to cluster metadata or anything else in Envoy. The only(?) concern...

> @PiotrSikora any thought about the explanation and use cases I have described? This seems to be a real issue that needs to be fixed, but the solution is not...

Thinking about this a bit more, maybe adding `send_grpc_response` where users can provide `grpc-status` would be a better solution?

> not sure adding a new method, many samples does not know in the wasm if the request comes from a grpc client. I guess the question is what problem...

> When a grpc client try to connect to grpc server and a wasm filter is in the filter chain that replay with unautorized, the wasm replay with -1 that...

> It makes sense to me and let envoy replay automatically, If you agree I could make envoy change to do it. Please do, thank you!