Js2Py
Js2Py copied to clipboard
Winfix for node_import
Recently users reported errors on windows machines regarding the error: "AssertionError: Could not link required node_modules" Even with the @alex-pancho fix on it on 2018, idk why it happened again in 2021. Theres the node_import file that I`m using and the solution worked fine. Please review this :)
Please @PiotrDabkowski review this :(
you can try also enable CI for windows, it failed before with some node modules error. may be after your fixes ci will works fine on windows?
See here https://github.com/PiotrDabkowski/Js2Py/blob/master/.github/workflows/tests.yml#L12
Thanks, a lot! Could you please enable windows to be tested as well ( as @4144 suggested)? With this we will be able to easily tell if it works.
It seems ubuntu and mac are now broken, we should ideally make sure that it works on all the platforms, windows, ubuntu, mac.