Color tools shouldn't be in modal dialogs
On GNOME, opening something in a modal dialog means the actual image content is dimmed. You just can't make a good choice when correcting with Brightness/Contrast or Curves because the content does not appear in its true tonality.
Moreover, if your point of interest is in the center of the image, you can't move the dialog around to see it. Instead, the entire Printa window unmaximizes and starts moving.
@Lehonti - this could be something to think about with your refactoring of the effect renderer. If the dialog is not modal, then Pinta either needs to block other edits to the image while the effect dialog is open, or be able to respond to changes that are made
Yeah, I could probably modify the method to use gtk_window_set_modal if the caller specifies it
This issue actually drives me insane.
None of the modals should obstruct the picture that you edit. It makes it impossible to know for certain if the result is what you want and you have to guess it. Live editing just doesn't exist with this situation.
Here's Pinta without any modals open:
Here is editing the picture with curves tool:
Here's layer properties:
Basically every time the modal/subwindow pops up, everything else is darkened.
At least on KDE Plasma you can move such modal even outside the main window.