Pinta icon indicating copy to clipboard operation
Pinta copied to clipboard

Customization of wave function for `TileReflection`

Open Lehonti opened this issue 1 year ago • 2 comments

The sharp, clear-cut edges of the tiles in TileReflection are achieved through the tangent function, which approaches infinite on one side and minus infinite on the other side, resulting in very sudden jumps.

But what if we chose a different function? For example if we chose sine, the image would be bulged in a tile pattern but it wouldn't have clear edges. Other functions would behave in different, interesting ways.

Lehonti avatar Oct 18 '24 01:10 Lehonti

This is cool, definitely has some interesting effects!

I'm mostly unsure about the naming of the Wave Type parameter and its menu options, which are pretty technical and might not make much sense to a user without an understanding of what the effect is doing internally. Ideally there could be some names that describe what behaviour is produced?

cameronwhite avatar Oct 20 '24 02:10 cameronwhite

@cameronwhite what names would you suggest?

Lehonti avatar Oct 20 '24 21:10 Lehonti

I haven't thought much about names for the new modes, but for example you might label the existing mode as Tile Shape -> Curved Edges or something like that? The current mode looks like the image is reflected in a mirror made up of tiles that have some curvature along their edges. Ideally we could have some labels for the new modes that give some idea of the general look of the effect

cameronwhite avatar Oct 23 '24 03:10 cameronwhite

@cameronwhite, since we're focusing on the visual effect rather than the wave function, I’ve narrowed the options down to two to start (we can add more tile types later). I named the enum TileType, with the options CleavedEdges (the existing type) and CurvedEdges (the new type). English isn’t my first language, so feel free to suggest different names if you think they would be more suitable.

Lehonti avatar Oct 25 '24 22:10 Lehonti

@cameronwhite I implemented your suggestions 👍

Lehonti avatar Oct 27 '24 18:10 Lehonti