Ping Xie

Results 339 comments of Ping Xie

>Each call of zmalloc will also call zmalloc_size to get the allocated size. And I observed the je_malloc_usable_size take about 6% CPU cycles. Sorry I meant to ask if you...

> I'm going to argue that although is possible, it doesn't seem like the right long term solution. Replication still seems like the better fit for pubsub compared to the...

Summarizing @valkey-io/core-team's discussion and thought process: 1. This is a breaking change. Standalone replicas can serve reads just fine today. This change when enabled would break the read-replica scenario for...

Even if we allow the client to opt-in via a new command like `CLIENT NODE REDIRECT`, we should not enable this particular behavior server-wide. This is because a Valkey server...

This is a very fine idea but the effectiveness of this feature apparently depends on clients being collaborative. Given the tricky client ecosystem situation, IMO, until we have a mature...

> @yangbodong22011 is very interested in being the maintainer for Jackey. We can initiate a vote to decide. Yeah, I am onboard with forking the clients now. With the amount...

sorry - human error. will re-open

single lines preserved. changes are mostly around spaces (missing spaces, extra spaces, trailing spaces, etc).

Also sharing core-team discussion: once this PR is merged, we will create a new github action to block future PRs if the new clang-format action ends up modifying the PRs.

@valkey-io/core-team can you please approve this PR?