ci icon indicating copy to clipboard operation
ci copied to clipboard

Remove mac test pipeline from storage repos

Open v01dstar opened this issue 11 months ago • 7 comments

TiKV's RocksDB's fork's CI disabled mac build anyway. And mac build is too slow in Titan's and rust-rocksdb's CI. So, disable mac build across storage repos' (RocksDB, Titan, rust-rocksdb) CI.

v01dstar avatar Jan 22 '25 04:01 v01dstar

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and diff, it seems that the change removes the test_mac pipeline from the titan_ghpr_test.groovy file in the jenkins/pipelines/ci/tikv/titan directory.

As for potential problems, it is not mentioned why the pipeline is being removed. If it is because it is no longer necessary, then there should be no issue. However, if it is removed because it is not working or causing issues, then this needs to be addressed.

If the pipeline is no longer necessary, it would be a good idea to add a brief explanation in the pull request description to clarify the rationale behind the change.

As for fixing suggestions, if the pipeline is being removed because it is not working or causing issues, it would be good to mention the steps taken to address the problem. Additionally, it would be helpful to provide any alternative solutions or pipelines that can be used to replace the removed pipeline.

ti-chi-bot[bot] avatar Jan 22 '25 04:01 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign purelind for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jan 22 '25 04:01 ti-chi-bot[bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the PR title and diff, the changes made are to remove the mac test pipeline from Titan. The PR removes the test_mac stage from the rocksdb_ghpr_test.groovy, rust_rocksdb_ghpr_test.groovy, and titan_ghpr_test.groovy files.

There are no potential problems identified in this PR. However, it is always a good practice to ensure that the changes made do not impact the functionality of other parts of the pipeline.

One suggestion to improve this PR is to add a brief description in the pull request description explaining the reason for removing the test_mac stage from the pipeline. This can help reviewers and future readers understand the purpose of this change.

ti-chi-bot[bot] avatar Jan 22 '25 04:01 ti-chi-bot[bot]

/cc @glorv @Connor1996

purelind avatar Jan 23 '25 07:01 purelind

Will this change increase the likelihood of TiKV failing to build on macOS?

purelind avatar Jan 23 '25 07:01 purelind

Many of us are still developing on mac, we better not disable it. Why tests run slow on macos?

I think this is because the currently available Mac machine is the Mac Mini with an Intel i7 chip, which has relatively weak performance.

purelind avatar Jan 23 '25 09:01 purelind

How about using mac-arm? @purelind is that a good option? from resource perspective?

v01dstar avatar Jan 23 '25 21:01 v01dstar

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.