Pincer icon indicating copy to clipboard operation
Pincer copied to clipboard

:bug: fix Channel.send `message` type

Open ooliver1 opened this issue 3 years ago • 2 comments

Changes

  • adds: ...
  • fixed: fixes #414
  • improvements: Uses utils.MessageConvertable for Channel.send's message param.

Check off the following

  • [x] I have tested my changes with the current requirements
  • [x] My Code follows the pep8 code style.

ooliver1 avatar Oct 01 '22 14:10 ooliver1

Once again the check failures are not related :sweat_smile:

ooliver1 avatar Oct 01 '22 14:10 ooliver1

Codecov Report

Base: 64.79% // Head: 64.78% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (09abdd5) compared to base (4072089). Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #518      +/-   ##
==========================================
- Coverage   64.79%   64.78%   -0.02%     
==========================================
  Files         184      184              
  Lines        5993     5994       +1     
==========================================
  Hits         3883     3883              
- Misses       2110     2111       +1     
Impacted Files Coverage Δ
pincer/objects/guild/channel.py 59.70% <50.00%> (-0.30%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 01 '22 14:10 codecov[bot]

Ngl i would need to dig into pincer to remember what is a MessageConvertable x)

Sigmanificient avatar Oct 02 '22 10:10 Sigmanificient