Quests icon indicating copy to clipboard operation
Quests copied to clipboard

Shift-clicking to craft multiple stacks of and item will only count as one stack toward quest objective progress

Open MarxminSD opened this issue 3 years ago • 3 comments

What is your Quests version / build number (do not say "latest")?

Quests 4.4.0-b325

Describe the problem and how to replicate it.

If I want to create a quest that requires a player to craft 512 or 8 stacks Oak Planks, I would need to set it up as so, since the limit is 64 when creating item crafting/smelting requirements in game: (I used 8 stacks of oak logs to fulfill the one below when shift-clicking, as opposed to 2 stacks) image image

When the player goes to craft the planks, if they use a stack of Oak Logs and shift-click planks, it will only fulfill one of the above objectives, although 256 were crafted.

**You can set limits above 64 in the quests.yml and it functions normally, but I don't think it's common knowledge and found out via the Discord support 👍

Any console errors to share?

No console errors.

If applicable, can you provide an example quest from quests.yml?

'3':
          items-to-craft:
          - ==: org.bukkit.inventory.ItemStack
            v: 2975
            type: OAK_PLANKS
            amount: 64
          items-to-craft:
          - ==: org.bukkit.inventory.ItemStack
            v: 2975
            type: OAK_PLANKS
            amount: 64
          items-to-craft:
          - ==: org.bukkit.inventory.ItemStack
            v: 2975
            type: OAK_PLANKS
            amount: 64
          items-to-craft:
          - ==: org.bukkit.inventory.ItemStack
            v: 2975
            type: OAK_PLANKS
            amount: 64
          items-to-craft:
          - ==: org.bukkit.inventory.ItemStack
            v: 2975
            type: OAK_PLANKS
            amount: 64
          items-to-craft:
          - ==: org.bukkit.inventory.ItemStack
            v: 2975
            type: OAK_PLANKS
            amount: 64
          items-to-craft:
          - ==: org.bukkit.inventory.ItemStack
            v: 2975
            type: OAK_PLANKS
            amount: 64
          items-to-craft:
          - ==: org.bukkit.inventory.ItemStack
            v: 2975
            type: OAK_PLANKS
            amount: 64
          items-to-smelt:
          - ==: org.bukkit.inventory.ItemStack
            v: 2975
            type: STONE
            amount: 64
          items-to-smelt:
          - ==: org.bukkit.inventory.ItemStack
            v: 2975
            type: STONE
            amount: 64
          - ==: org.bukkit.inventory.ItemStack
            v: 2975
            type: IRON_INGOT
            amount: 64
          - ==: org.bukkit.inventory.ItemStack
            v: 2975
            type: IRON_INGOT
            amount: 64

MarxminSD avatar Apr 30 '22 18:04 MarxminSD

The picture shows you're crafting multiple stacks of planks, but the example quest says every stack after the first one is being smelted?

PikaMug avatar May 10 '22 11:05 PikaMug

Ah - that was a typo; I had since changed the original config to use the amount of 512, and when creating the example for this post, copied and pasted from a random entry in the .yml, and forgot to change. Fixed now, but can confirm the issue persist with multiple entries of "items-to-craft:" instead of "items-to-smelt:"

MarxminSD avatar May 10 '22 17:05 MarxminSD

Fixed in the example! 👍

MarxminSD avatar May 10 '22 17:05 MarxminSD

Sorry I'm just getting around to this now. The example is still invalid—there can only be one of each type of objective per stage (the plugin will ignore the duplicate items-to-craft and items-to-smelt nodes). Feel free to correct the example further if desired and request re-open.

PikaMug avatar Mar 03 '23 01:03 PikaMug