Kate Lovett comments

Results 588 comments of


                                            Kate Lovett

Linux_pixel_7pro flavors_test is 3.00% flaky

Looks like this was updated to P2, but the bot removed that because P0 was still there. I think I have fixed it. :)

`PopupRoute` and `ModalRoute` should use `OverlayPortal`

FYI @chunhtai, what do you think?

[go_router_builder] Add support for relative routes

I am working on an updated workflow for flutter/packages to remove the pain point of the changelog and version merge conflicts, hoping to get that out sooner rather than later....

[go_router_builder] Add support for relative routes

@hannah-hyj I noticed you mentioned in https://github.com/flutter/packages/pull/8665 that PRs should be split between go_router and go_router_builder. Is that not relevant here?

[go_router_builder] Add support for relative routes

Hey @ThangVuNguyenViet I'd love to help you get this in. Currently there are several failing tests, can you take a look?

[go_router_builder] Add support for relative routes

> I've removed 1 breaking change that that PR made I don't think undoing the other change as part of this one is the right course of action. That change...

[various] Add `missing_code_block_language_in_doc_comment` lint to flutter/packages.

(PR triage): What is the status of this PR?

[various] Add `missing_code_block_language_in_doc_comment` lint to flutter/packages.

Hmm, I am not sure. @stuartmorgan would likely be best to advise. I think you would have to bump the dependency on each affected package to make it no longer...

Update `chip.dart` to use set of `MaterialState`

> My proposal is, either to make chip.dart consistent with the rest of the framework to maintain material states by removing MaterialStateMixin and using a set of material state or...

Shared element transition for predictive back

@maRci002 do you plan to continue working on this PR?