PierreRochard
Feature request: Recently updated sort that ignores bots
Possible feature request from IRC discussion. Maybe bitcoin-acks can provided a list of recently updated PRs that ignores DrahtBot comments:
<gmaxwell> breaking sort by recently updated has probably reduced the amount of review I do by 80%, FWIW. <gmaxwell> as I'd typical go and sort by updated and check in on all the active PRs. <wumpus> luke-jr: yes that would be preferable, but I do not know if github provides that functionality to random developers, lacking that, sipa's idea to post once then update is a good idea <sipa> actually, a top comment that gets updated may not be enough to un-break it; the PRs that get newly referenced by another post's "conflicts with" will still be marked as recently updated <gmaxwell> another alternative would be to just post some external thing with the real recently updated data. <gmaxwell> e.g. go scrap github or new commits every couple hours and post a report somewhere. <gmaxwell> scrape* <wumpus> gmaxwell: ah yes kind of what bitcoinacks.com does
Three alternatives I see in order of how often they'd get triggered:
- sort by most recent human comment
- sort by most recent *ACK
- sort by most recent code push to branch
Personally I would think the last one, sort when the PR's code has actually changed, would be the most useful, but I'd be interested in hearing what others have to say
Interesting, I could think of uses for all three. I think I'd mostly use (1) and (3), but (2) could be useful for maintainers.
I guess it didn't occur to me that adding sorting options might require making the table wider. That does seem like a problem.
Ideally I might want just a single Date column and a customization or dropdown that would let me choose whether the Created, Updated, Commented, Pushed, or ACKed date is shown there. By default I think I would want the Commented date.
Other people should chime in here, though if they would use this feature.
@PierreRochard How hard would it be to implement this? How about supporting all 3 options use cite above?
I think the "sort by most recent code push to branch" is the easiest and most helpful of the three options
@MarcoFalke indeed that was pretty easy, it's live now
I still want to eventually implement @ryanofsky's ideal approach with a custom widget (Ideally I might want just a single Date column and a customization or dropdown that would let me choose whether the Created, Updated, Commented, Pushed, or ACKed date is shown there. By default I think I would want the Commented date.) , if just to make the table less wide