reACK incorrectly detected as Concept ACK

Open achow101 opened this issue 3 years ago • 1 comments

reACKs are being detected as Concept ACKs when they should be Tested ACKs if followed by a commit hash.

Example: https://github.com/bitcoin/bitcoin/pull/19762#pullrequestreview-1194960992

Nov 29 '22 23:11 achow101

For reference, this is DrahtBot's code:

https://github.com/MarcoFalke/DrahtBot/blob/5fed5b7b475a3745f477d62431dfb29924ed622d/webhook_features/src/features/summary_comment.rs#L303

Nov 30 '22 13:11 maflcko