Pierre Tomasina comments

Results 89 comments of


                                            Pierre Tomasina

case-insensitive for Operator name

Done :+1:

case-insensitive for Operator name

Quick review ?

case-insensitive for Operator name

It seems casting of Extended ASCII work only from php >= 5.6 as Travis build report.

Decimals without a leading integer cause errors

Like it seems all calculator (physically or virtual) allow to begin by dot for decimal it should be a good idea to follow the same common usage.

fix(read stream) consume buffer multiple times

We can merge this one first, I will adapt #50 when php5.x will be dropped.

fix(read stream) consume buffer multiple times

the buffer 2048 it's only for the handshake, it should be lower than that, expect if insert very long content in headers.

fix(read stream) consume buffer multiple times

the read method should stop at length or EOF according the result of `stream_socket_recvfrom` or `fread` do you encounter any problem?

fix(read stream) consume buffer multiple times

So, I've taken some time to deep dive into this issue. My original patch works great when Stream is not in blocking mode, and solve the issue related to read...

fix(read stream) consume buffer multiple times

@Hywan ping there

fix(read stream) consume buffer multiple times

I need to check related to `Hoa\Stream` but I guess it's a good option.