ConnectivityManger leaks the context on Android 12

[frett]

the context object getSystemService() is called on is leaked via ConnectivityManager.sInstance

[PierfrancescoSoffritti]

Hi, thanks for the PR. How is your patch different from the previous implementation?

[frett]

Here is a debugger stack trace of when the ConnectivityManager.sInstance variable is being set with a ConnectivityManager instance that references an Activity context. The context object that is passed into the NetworkListener.onReceive() method is the activity context class, and not the application context class. So, getting the applicationContext out of the Activity before getting the ConnectivityManager service will prevent the Activity leaking via the sInstance static variable.

This stack trace is from a Pixel 4a running Android 12, I haven't tried running it on older versions of Android yet to determine if the leak was present before or if it's a new leak in Android 12

[PierfrancescoSoffritti]

Hi @frett , I am sorry for the very very late reply. As the single maintainer of the lib it's sometimes hard to keep up with everything going on.

Your PR is correct, the Context was indeed leaked. I have fixed this recently, see #924. Again sorry for not addressing this sooner.