Zoltán Lehóczky

Results 1162 comments of Zoltán Lehóczky

Did you submit your comments? Because nothing appears for me here.

I'd appreciate if before these questions you'd please take a look at what the reviewer has written; it's a recurring theme that I come back with links to my prior...

Well, then something needs to change because this is really confusing UX. BTW the wrong configuration is the default when you add a new policy. Please also remove that footgun.

I just noticed: https://github.com/OrchardCMS/OrchardCore/blob/8bac37a0fed82d8596c6ca943ac33fc9917c4e67/src/OrchardCore.Modules/OrchardCore.Cors/Services/CorsOptionsConfiguration.cs#L28-L32 Apparently, this isn't working well enough. This is what needs to be fixed.

> That's why I show the warning on the UI to let the user know there's something that needs attention Saving (seemingly) the policy while showing a warning that it's...

No idea what the exact intent here was, but please formulate the problem and suggested fix in more detail. Also check out, there were discussions about this not long ago...

These are two separate issues. Could you please split the dark mode one out to a new issue? The click behavior I'm pretty sure is related to a Trumbowyg update....

@hishamco could you please check?

See https://github.com/OrchardCMS/OrchardCore/pull/18356#issuecomment-3300262624: > So, I don't think such a change is beneficial. But if you have really good arguments in favor of it, then please bring it up at one...